This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Refactor: Move views to GitHub.VisualStudio.UI#1955
Merged
Conversation
This will be needed to prevent circular references when we move the views from GitHub.InlineReviews out of that assembly.
Open
jcansdale
approved these changes
Sep 28, 2018
Collaborator
jcansdale
left a comment
There was a problem hiding this comment.
This looks like a worthwhile change. I'm all for getting as much out of GitHub.VisualStudio as possible!
Hopefully we can move the commands and services out in another PR. 🤞
Conflicts: src/GitHub.VisualStudio.UI/Views/Dialog/Clone/RepositoryCloneView.xaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was made necessary when I started work on issues. Issues and PRs share a number of views/view models relating to comments. Previously these views/view models were in the GitHub.InlineReviews assembly, but issues don't belong in that assembly.
The view models could be moved into GitHub.App without problems but in order for both GitHub.VisualStudio and GitHub.InlineReviews to access the views, they need to be moved into an assembly that can be accessed from both (GitHub.InlineReviews cannot reference GitHub.VisualStudio because that would create a circular reference).
To solve this, views can be defined in GitHub.VisualStudio.UI (if I remember correctly @shana always intended to move views here). This PR moves all views to that assembly as well as moving the required view models from GitHub.InlineReviews into GitHub.App.